Bug 536730 - memory corruption in gtktreeview

2008-06-08  Kristian Rietveld  <kris@gtk.org>

	Bug 536730 - memory corruption in gtktreeview

	* gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): first
	remove the expand/collapse timeout and node, then free the rbtree.

svn path=/trunk/; revision=20334

diff --git a/ChangeLog b/ChangeLog
index 0c9ace1437fd803cd3b35ef240688303399a139f..1d1bee32488a398199258afbbd3003d50be3c3c5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-06-08  Kristian Rietveld  <kris@gtk.org>
+
+       Bug 536730 - memory corruption in gtktreeview
+
+       * gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): first
+       remove the expand/collapse timeout and node, then free the rbtree.
+
 2008-06-08  Kristian Rietveld  <kris@gtk.org>
 
        Bug 488119 - critical warnings from gtk_tree_view_get_visible_range

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index 1a014828337949c13d0af12e14940e036a88e7d6..dc952963e742e1c70f79a4147ad8552660e41c03 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -12217,6 +12217,8 @@ gtk_tree_view_real_collapse_row (GtkTreeView *tree_view,
       gtk_tree_path_free (lsc);
     }
 
+  remove_expand_collapse_timeout (tree_view);
+
   if (gtk_tree_view_unref_and_check_selection_tree (tree_view, node->children))
     {
       _gtk_rbtree_remove (node->children);
@@ -12224,8 +12226,6 @@ gtk_tree_view_real_collapse_row (GtkTreeView *tree_view,
     }
   else
     _gtk_rbtree_remove (node->children);
-
-  remove_expand_collapse_timeout (tree_view);
   
   if (animate)
     add_expand_collapse_timeout (tree_view, tree, node, FALSE);